[webkit-reviews] review denied: [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display(). : [Attachment 45733] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 33096: [Qt] DRT: Support evaluateInWebInspector(),
setTimerProfilingEnabled() and display().
https://bugs.webkit.org/show_bug.cgi?id=33096

Attachment 45733: Patch
https://bugs.webkit.org/attachment.cgi?id=45733&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
How does this interact with the central LayoutTestController code?
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/LayoutTestContr
oller.cpp#L865

Does Qt not use that code?

Also, it seems that the x-platform LayoutTestController turns off profiling
after every test, which it seems you might need to do too.  I think this patch
is wrong, or at least incomplete judging by my quick scan of
LayoutTestController.cpp.  Feel free to re-mark this r? if I'm
misunderstanding.