[webkit-reviews] review requested: [Bug 33098] Refactor svn-apply and svn-unapply to use a common "patch" method : [Attachment 45738] Proposed patch 2

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 33098: Refactor svn-apply and svn-unapply to use a common "patch" method
https://bugs.webkit.org/show_bug.cgi?id=33098

Attachment 45738: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=45738&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
Except for the unit tests on Windows, I believe this addresses what you wanted
me to address.	Of course, it's also possible that the changes introduced new
things that need to be addressed.

Regarding exitStatus(), it turns out that webkitdirs.pm already references
VCSUtils.pm (I hadn't known that when I responded to you before).  So I was
simply able to move the implementation of exitStatus() from webkitdirs.pm to
VCSUtils.pm, and leave behind a subroutine declaration inside webkitdirs.