[webkit-reviews] review requested: [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display(). : [Attachment 45733] Patch

[bugzilla-daemon at webkit.org]

Robert Hogan <robert at roberthogan.net> has asked  for review:
Bug 33096: [Qt] DRT: Support evaluateInWebInspector(),
setTimerProfilingEnabled() and display().
https://bugs.webkit.org/show_bug.cgi?id=33096

Attachment 45733: Patch
https://bugs.webkit.org/attachment.cgi?id=45733&action=review

------- Additional Comments from Robert Hogan <robert at roberthogan.net>
The following inspector tests are unresolved by this patch:

 inspector/console-dir.html
 inspector/console-dirxml.html
 inspector/console-format.html
 inspector/console-tests.html
 inspector/console-clear.html
 inspector/console-format-collections.html

They continue to fail because the console message prints an absolute file://
url for the inspected page, rather than a relative one. gdb crashes when
loading the DRT for me unless it's a --minimal build so was not able to look
into this one for now.