[webkit-reviews] review requested: [Bug 35502] [Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText : [Attachment 49706] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 28 16:31:35 PST 2010


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 35502: [Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
https://bugs.webkit.org/show_bug.cgi?id=35502

Attachment 49706: proposed fix
https://bugs.webkit.org/attachment.cgi?id=49706&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
One line fix that seems to solve the problem.

So... How does one write a test to verify that AtkText is *not* implemented? In
other words, doesn't testing that tables do not implement AtkText cause the
test to fail because AtkText is no longer implemented for tables? :-/

Ideas welcome if this fix must have a test in order to be accepted. Thanks!


More information about the webkit-reviews mailing list