[webkit-reviews] review denied: [Bug 35087] New port: EFL; adding files to WebCore/*/efl : [Attachment 49614] Patch 4/7 to WebCore/platform/efl

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35087: New port: EFL; adding files to WebCore/*/efl
https://bugs.webkit.org/show_bug.cgi?id=35087

Attachment 49614: Patch 4/7 to WebCore/platform/efl
https://bugs.webkit.org/attachment.cgi?id=49614&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +#include "config.h"
> +#include "KURL.h"
> +
> +#include "CString.h"
> +
> +#include <Ecore.h>
> +
> +namespace WebCore {
> +
> +String KURL::fileSystemPath() const
> +{
> +    char* filename = (char*)m_string.utf8().data();
> +    if (!filename)
> +	   return String();
> +
> +    String path = String::fromUTF8(filename);
> +    free(filename);
> +    return path;


Sorry, I stopped here reading. The memory returned by .data() will be dead
shortly afterwards, calling free (filename) is certainly not right. The whole
method seems to be bogus though. :)