[webkit-reviews] review denied: [Bug 35162] Configure the root logging.logger globally for the Python scripts : [Attachment 49256] Proposed patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 15:17:50 PST 2010


Chris Jerdonek <cjerdonek at webkit.org> has denied Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35162: Configure the root logging.logger globally for the Python scripts
https://bugs.webkit.org/show_bug.cgi?id=35162

Attachment 49256: Proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=49256&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
I am having second thoughts about this approach.  It is probably better for
each script to be responsible for turning on its own logging (an opt-in
approach), rather than turning on logging simply by importing from webkitpy. 
This should also resolve the issue of having to turn off logging for the unit
tests.


More information about the webkit-reviews mailing list