[webkit-reviews] review denied: [Bug 35261] [Skia] crash when attempting to render certain SVGs : [Attachment 49634] test case fixed

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 35261: [Skia] crash when attempting to render certain SVGs
https://bugs.webkit.org/show_bug.cgi?id=35261

Attachment 49634: test case fixed
https://bugs.webkit.org/attachment.cgi?id=49634&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for "Nobody" which will make cq fail.

> Index: WebCore/ChangeLog
> +2010-02-25  Evan Stade  <estade at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=35261
> +	   [skia] crash when attempting to render certain SVGs
> +
> +	   This fixes the crash, but the SVG still doesn't render properly.
> +
> +	   Test: svg/custom/tiling-regular-hexagonal-crash.svg
> +
> +	   * platform/graphics/skia/ImageSkia.cpp:
> +	   (WebCore::BitmapImageSingleFrameSkia::create): don't return NULL
when
> +	   the copy fails; instead return a blank bitmap. The caller doesn't
> +	   check for NULL before dereferencing.

Better to use "0" instead of "NULL" since the code never uses "NULL".


> Index: LayoutTests/ChangeLog
> +2010-02-25  Evan Stade  <estade at chromium.org>
> +
> +	   Reviewed by Nobody (OOPS!).

This is going to fail to commit because the script greps for NOBODY, so the
line won't get replaced and it will fail to commit.