[webkit-reviews] review denied: [Bug 34356] REGRESSION: Arrow keys do not scroll source view in Resources pane or text editor in Scripts pane : [Attachment 49626] Also patch TextViewer.js

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 34356: REGRESSION: Arrow keys do not scroll source view in Resources pane
or text editor in Scripts pane
https://bugs.webkit.org/show_bug.cgi?id=34356

Attachment 49626: Also patch TextViewer.js
https://bugs.webkit.org/attachment.cgi?id=49626&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> ===================================================================
> --- WebCore/inspector/front-end/AbstractTimelinePanel.js	(revision
55293)
> +++ WebCore/inspector/front-end/AbstractTimelinePanel.js	(working copy)

This file should not change. Changes to the TextViewer.js should be sufficient
to cover all viewers' scrolling.

> +	   var scrollLines = 0;
> +	   if (event.keyCode === WebInspector.KeyboardShortcut.KeyCodes.Up)
> +	       scrollLines = -1;
> +	   else if (event.keyCode ==
WebInspector.KeyboardShortcut.KeyCodes.Down)
> +	       scrollLines = 1;
> +	   
> +	   if (scrollLines) {
> +	       event.preventDefault();
> +	       event.stopPropagation();
> +	       this.containerElement.scrollByLines(scrollLines);

> +	   var scrollLines = 0;
> +	   if (event.keyCode === WebInspector.KeyboardShortcut.KeyCodes.Up)
> +	       scrollLines = -1;
> +	   else if (event.keyCode ==
WebInspector.KeyboardShortcut.KeyCodes.Down)
> +	       scrollLines = 1;

This way Cmd + Up is going to be treated as one-line step. You should only
consume Arrow events with no modifiers.

Btw, what's going on to the Left / Right? Now that we don't wrap lines we might
need to handle them as well.