[webkit-reviews] review granted: [Bug 35445] [OpenVG] Convert from TransformationMatrix to AffineTransform : [Attachment 49615] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 12:59:37 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Jakob Petsovits
<jpetsovits at rim.com>'s request for review:
Bug 35445: [OpenVG] Convert from TransformationMatrix to AffineTransform
https://bugs.webkit.org/show_bug.cgi?id=35445

Attachment 49615: Patch
https://bugs.webkit.org/attachment.cgi?id=49615&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Patch looks fine, r=me.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index cd85ac2..d539832 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,36 @@
> +2010-02-26  Jakob Petsovits	<jpetsovits at rim.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [OpenVG] Convert from TransformationMatrix to AffineTransform.
> +

the ChangeLog is missing a bug number and a good explainatain to why this is
done.
It shouldn't be necessary to look in the bug to get that information :-)

Please fix before landing.


More information about the webkit-reviews mailing list