[webkit-reviews] review denied: [Bug 34356] REGRESSION(canvas editor): Arrow keys do not scroll source view in Resources pane : [Attachment 49608] Simple fix.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 34356: REGRESSION(canvas editor): Arrow keys do not scroll source view in
Resources pane
https://bugs.webkit.org/show_bug.cgi?id=34356

Attachment 49608: Simple fix.
https://bugs.webkit.org/attachment.cgi?id=49608&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>  /*
> - * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc.  All rights reserved.

We would put just 2010 here, not sure about you folks thought.

>	   this._containerContentElement.id = "resources-container-content";
> +	   this._containerContentElement.tabIndex = 0;
> +	   this._containerContentElement.addEventListener("keydown",
this._handleKeyDownForScroll.bind(this), false);

You should put this code into the TextViewer.js. Otherwise Scripts panel is not
affected with your changes.

>  
> +    _handleKeyDownForScroll: function(event)
> +    {

I'd call it _handleKeyDown since it is registered for all keyboard events, not
necessarily related to the scrolling. Also should be in TextViewer.js