[webkit-reviews] review denied: [Bug 35362] Parsing of CSS rgb() values is slow : [Attachment 49597] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 26 10:20:20 PST 2010
Oliver Hunt <oliver at apple.com> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 35362: Parsing of CSS rgb() values is slow
https://bugs.webkit.org/show_bug.cgi?id=35362
Attachment 49597: Patch
https://bugs.webkit.org/attachment.cgi?id=49597&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
I would be interested in what you get for perf numbers if you replace
isCSSWhitespace with a simplified ' ' and '\t' only check -- on the basis we
are wanting to get the maximum perf out of the normal case.
Also my reading of this seems to indicate that this will accept
rgb(1,1,1)<random text>
More information about the webkit-reviews
mailing list