[webkit-reviews] review denied: [Bug 35418] [Gtk] Every table, including layout tables, should be exposed as a table : [Attachment 49563] proposed fix - style nit corrected

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 23:14:29 PST 2010


Xan Lopez <xan.lopez at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 35418: [Gtk] Every table, including layout tables, should be exposed as a
table
https://bugs.webkit.org/show_bug.cgi?id=35418

Attachment 49563: proposed fix - style nit corrected
https://bugs.webkit.org/attachment.cgi?id=49563&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+#if PLATFORM(GTK)
>+    // Gtk ATs expect all tables, data and layout, to be exposed as tables.
>+    if (node && (node->hasTagName(tdTag)))
>+	  return CellRole;
>+
>+    if (node && (node->hasTagName(tableTag)))
>+	  return TableRole;
>+#endif

The parenthesis around the second term in each if are not reeded.
 
Other that that looks good, if you can attach a new patch with that detail
fixed I'll r+ it.


More information about the webkit-reviews mailing list