[webkit-reviews] review granted: [Bug 35399] [Chromium] Chromium doesn't preserve hash fragments on about:blank URLs : [Attachment 49518] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 25 15:59:26 PST 2010
Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 35399: [Chromium] Chromium doesn't preserve hash fragments on about:blank
URLs
https://bugs.webkit.org/show_bug.cgi?id=35399
Attachment 49518: Patch
https://bugs.webkit.org/attachment.cgi?id=49518&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.
Instead of mentioning the current behavior of Safari and Chrome in your test, I
would simply state what the test does. Since eventually all browsers will pass
that test.
You used 2-space indent in your JS.
Fix those nits and land away! :)
More information about the webkit-reviews
mailing list