[webkit-reviews] review denied: [Bug 35198] Move pywebsocket into webkitpy/thirdparty : [Attachment 49135] Proposed patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35198: Move pywebsocket into webkitpy/thirdparty
https://bugs.webkit.org/show_bug.cgi?id=35198

Attachment 49135: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49135&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I like everything here (I've very much disliked having this external code look
like it could be webkit code but have different conventions about things).

I have one request, since this is a large module, I would love for it to have a
README.webkit (just inside of its directory). Ideally, it should explain how to
get the code, the current revision obtained, and any local modifications. (How
to get the code is in this bug, the current revision obtained is unknown but
could be filled in the next time this module is updated, there are no local
modifications).


Here's a possible example (though it says more than what I mentioned):
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/lzma_sdk/README.chr
omium?view=markup