[webkit-reviews] review canceled: [Bug 35387] [Qt] Sometimes QScriptValue::isObject returns an incorrect value : [Attachment 49493] Fix v1

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has canceled Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 35387: [Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387

Attachment 49493: Fix v1
https://bugs.webkit.org/attachment.cgi?id=49493&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
(In reply to comment #3)
> Looks good, except for the misspelling in the doc for refineJSValue
> ("retruns"), and I think it should say "Refines the state of this ... and
> returns the new state". No reason to use different wording in the description

> when the function already has a descriptive name.
Done.

As previous patch this one is dependent on bug 34850, that means it cant be
applied right now. I have tried apply it on trunk;
~/dev/WebKit$ git apply -v /tmp/isObjectV2.diff
Checking patch JavaScriptCore/ChangeLog...
Checking patch JavaScriptCore/qt/api/qscriptvalue_p.h...
Checking patch
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp...
error: while searching for:
{
    QFETCH(bool, expected);
    QCOMPARE(value.isObject(), expected);
}

DEFINE_TEST_FUNCTION(isObject)

void tst_QScriptValue::toString_initData()
{
    QTest::addColumn<QString>("expected");

error: patch failed:
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:552
error: JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
patch does not apply