[webkit-reviews] review granted: [Bug 35184] Add another test case to the iframes-shims test : [Attachment 49486] Ensure that Widget is notified via a new method widgetPositionsUpdated() during RenderView::updateWidgetPositions()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 09:11:50 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Thatcher Ulrich
<tulrich at google.com>'s request for review:
Bug 35184: Add another test case to the iframes-shims test
https://bugs.webkit.org/show_bug.cgi?id=35184

Attachment 49486: Ensure that Widget is notified via a new method
widgetPositionsUpdated() during RenderView::updateWidgetPositions()
https://bugs.webkit.org/attachment.cgi?id=49486&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: LayoutTests/ChangeLog
...
> +2010-02-25  Thatcher Ulrich	<tulrich at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	Fix chromium iframe shims.  Add another test case to the
> +	iframes-shims test.  After r53637, the plugin widget doesn't get
> +	moved every paint.  This used to hide the bug that if an iframe
> +	gets added, the plugin's cutout rectangles don't get updated until
> +	a layout happens.

^^^ these tabs need to be replaced with spaces.

otherwise, R=me


More information about the webkit-reviews mailing list