[webkit-reviews] review granted: [Bug 35265] run-chromium-webkit-tests --platform=mac-leopard diffs are backwards : [Attachment 49441] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 35265: run-chromium-webkit-tests --platform=mac-leopard diffs are backwards
https://bugs.webkit.org/show_bug.cgi?id=35265

Attachment 49441: Patch
https://bugs.webkit.org/attachment.cgi?id=49441&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2010-02-24  Eric Seidel  <eric at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   run-chromium-webkit-tests --platform=mac-leopard diffs are backwards

> +	   https://bugs.webkit.org/show_bug.cgi?id=35265
> +
> +	   Some parts of the code passed arguments as
> +	   "actual, expected" and some passed as "expected, actual".
> +	   As you might imagine, this lead to great confusion and wrongness.
> +	   Standardize on "expected, actual" as that't the order which is

typo: that't

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
b/WebKitTools/Scripts/webkitpy/layout_tests/port/test.py
> -    def diff_text(self, actual_text, expected_text,
> -		     actual_filename, expected_filename):
> +    def diff_text(self, expected_text, actual_text,
> +	       expected_filename, actual_filename):
It would be nice to align to the ( of the previous line (as was done before).