[webkit-reviews] review granted: [Bug 35213] [chromium] hardcoded gcc path breaks solaris build : [Attachment 49488] even more formatting edits

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted electricmonopole at gmail.com's
request for review:
Bug 35213: [chromium] hardcoded gcc path breaks solaris build
https://bugs.webkit.org/show_bug.cgi?id=35213

Attachment 49488: even more formatting edits
https://bugs.webkit.org/attachment.cgi?id=49488&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'll do these fixes and land it.


There should be spaces around the ~= as noted previously but I missed this in
the last review :(.

> Index: WebCore/dom/make_names.pl

This could be slightly simpler my moving where preprocessor is declared.

> +require Config;
> +my $gccLocation = "";
> +if (($Config::Config{'osname'})=~/solaris/i) {
> +    $gccLocation = "/usr/sfw/bin/gcc";
> +} else {
> +    $gccLocation = "/usr/bin/gcc";
> +}
> +my $preprocessor = $gcclocation . " -E -P -x c++";

Something I didn't mention before: I think the comment "Detect OS. ..." is
redundant with the code (-- It is a translation of the code into English so it
doesn't seem useful), so it should be removed.