[webkit-reviews] review denied: [Bug 35340] [Qt] Enable alternate HTML/JavaScript front-ends for Web Inspector : [Attachment 49418] revised patch to fix style problems in WebKit/qt/ChangeLog

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Jamey Hicks
<jamey.hicks at nokia.com>'s request for review:
Bug 35340: [Qt] Enable alternate HTML/JavaScript front-ends for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=35340

Attachment 49418: revised patch to fix style problems in WebKit/qt/ChangeLog
https://bugs.webkit.org/attachment.cgi?id=49418&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Approach looks good to me, this is a great addition to QtWebKit.

ChangeLog does not seems to follow the template. The "Reviewed by NOBODY
(OOPS!)." part is missing. Also I have added [Qt] to the title of the bug, so
if you could regenerate the ChnageLog that would be good.

Based on IRC discussion with Kenneth, Jamey and myself we concluded the the API
for setting/getting the Inspector URL should be:

void QWebSettings::setInspectorUrl (const QUrl &inspector);
QUrl QWebSettings::inspectorUrl() const;

Please document these new APIs well.

This means that changes in InspectorClientQt.h would not be necessary but your
style fixes are very welcome.

r- to use the new proposed API; general approach is good.