[webkit-reviews] review requested: [Bug 35153] [Qt] WebGL support missing in QtWebKit : [Attachment 49475] Qt WebGL support

[bugzilla-daemon at webkit.org]

Jarkko Sakkinen <jarkko.sakkinen at tieto.com> has asked  for review:
Bug 35153: [Qt] WebGL support missing in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35153

Attachment 49475: Qt WebGL support
https://bugs.webkit.org/attachment.cgi?id=49475&action=review

------- Additional Comments from Jarkko Sakkinen <jarkko.sakkinen at tieto.com>
- Fixed compiler warning: forgot to remove now unused local variable ctx
- Fixed compiler error on desktop compilation:
GraphicsContext3D::DEPTH_COMPONENT24 -> GraphicsContext3D::DEPTH_COMPONENT

NOTE: If WTF_USE_ACCELERATED_COMPOSITING is disabled the current qtwebkit
master does not compile. Resolved this by following change (not included in
this patch since this is not part of this):

diff --git a/WebCore/css/MediaQueryEvaluator.cpp
b/WebCore/css/MediaQueryEvaluator.cpp
index 4963ed4..6864231 100644
--- a/WebCore/css/MediaQueryEvaluator.cpp
+++ b/WebCore/css/MediaQueryEvaluator.cpp
@@ -47,7 +47,7 @@
 #include "PlatformScreen.h"
 #include <wtf/HashMap.h>
 
-#if ENABLE(3D_RENDERING)
+#if ENABLE(3D_RENDERING) && USE(ACCELERATED_COMPOSITING)
 #include "RenderLayerCompositor.h"
 #endif
 
@@ -472,10 +472,12 @@ static bool transform_3dMediaFeatureEval(CSSValue* value,
RenderStyle*, Frame* f
     bool returnValueIfNoParameter;
     int have3dRendering;
 
-#if ENABLE(3D_RENDERING)
+#if ENABLE(3D_RENDERING) 
     bool threeDEnabled = false;
+#if USE(ACCELERATED_COMPOSITING)
     if (RenderView* view = frame->contentRenderer())
	 threeDEnabled = view->compositor()->hasAcceleratedCompositing();
+#endif
 
     returnValueIfNoParameter = threeDEnabled;
     have3dRendering = threeDEnabled ? 1 : 0;