[webkit-reviews] review requested: [Bug 33995] Web Inspector: Additional instrumentation for Timeline : [Attachment 49472] Patch with adjusted Popover.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 03:05:09 PST 2010


Ilya Tikhonovsky <loislo at google.com> has asked	for review:
Bug 33995: Web Inspector: Additional instrumentation for Timeline
https://bugs.webkit.org/show_bug.cgi?id=33995

Attachment 49472: Patch with adjusted Popover.
https://bugs.webkit.org/attachment.cgi?id=49472&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at google.com>
1) Popup title was added;
2) Event type was removed;
3) Timer Id was added;
4) Installed at was renamed;
5) Start and Duration were mixed together;
6) Join of Function Call and Timer Fired event will be implemented later;
7) I'm not sure that jump from Timer Fired event to Timer Install event will be
useful, because this step will add additional indirection 
and after such jump the user should seek again initial Timer Fire event if he
wants to continue its investigation in Timeline Panel;
8) Row highlight will be implemented later;
9) padding at bottom was removed but we definitely need a space for scroller
and scroller space was added at right side of Popover;
10) hideAtClick was renamed.


More information about the webkit-reviews mailing list