[webkit-reviews] review granted: [Bug 35367] fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac : [Attachment 49449] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 35367: fix check_sys_deps/start_helper ordering, and fix check_sys_deps
proto on mac
https://bugs.webkit.org/show_bug.cgi?id=35367

Attachment 49449: Patch
https://bugs.webkit.org/attachment.cgi?id=49449&action=review

------- Additional Comments from David Levin <levin at chromium.org>
two things to consider below.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +	   http://ubgs.webkit.org/show_bug.cgi?id=35367

typo: "ubgs"

> diff --git
a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py
b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py

> +    # Check that the system dependencies (themes, fonts, ...) are correct.
> +    if not options.nocheck_sys_deps:
> +	   if not port_obj.check_sys_deps(test_runner.needs_http()):

Why not do an "and" instead of nested if's.

> +	       sys.exit(1)