[webkit-reviews] review granted: [Bug 35322] Need to create a CanvasSurface base class for HTMLCanvasElement. : [Attachment 49404] Proposed fix.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 35322: Need to create a CanvasSurface base class for HTMLCanvasElement.
https://bugs.webkit.org/show_bug.cgi?id=35322

Attachment 49404: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=49404&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +/*
> + * Copyright (C) 2010 Google Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *	 notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *	 notice, this list of conditions and the following disclaimer in the
> + *	 documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> + * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
> + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
> + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
> + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
> + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include "config.h"
> +#include "CanvasSurface.h"
> +
> +namespace WebCore {
> +
> +} // namespace WebCore
> +

Extra blank line at end of file not needed.

> +namespace WebCore {
> +class CanvasSurface : Noncopyable {
> +public:
> +
> +private:
> +};
> +} // namespace WebCore

Need a blank line before and after the class definition.

Needs to be "public Noncopyable".

Doesn't make a lot of sense to me to have those "public" and "private" in
there, although I suppose there's no harm.

> +#include "TransformationMatrix.h"

Why this change? How does it relate to adding the include of "CanvasSurface.h"?