[webkit-reviews] review denied: [Bug 35257] Expose WebFrame::setCanHaveScrollbars() to Chromium : [Attachment 49414] Address review comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 11:07:24 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 35257: Expose WebFrame::setCanHaveScrollbars() to Chromium
https://bugs.webkit.org/show_bug.cgi?id=35257

Attachment 49414: Address review comments.
https://bugs.webkit.org/attachment.cgi?id=49414&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 55194)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,20 @@
> +2010-02-24  Sam Kerner  <skerner at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Expose WebFrame::setCanHaveScrollbars().  This allows a view
> +	   which is being resized to not need scroll bars to ensure that
> +	   they are not drawn.
> +
> +	   Existing function setAllowsScrolling() was renamed
> +	   setCanHaveScrollbars(), to be consistant with change 37159:
> +	   http://trac.webkit.org/changeset/37159

I meant that you should include a link to this bug report:
https://bugs.webkit.org/show_bug.cgi?id=35257

That way when someone reads the ChangeLog they can jump back to this
bug report, where the code review and related discussions took place.


More information about the webkit-reviews mailing list