[webkit-reviews] review denied: [Bug 35347] Convert the zoom mode into a proper enum : [Attachment 49401] Convert the zoom mode into a proper enum

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetsovits at rim.com>'s
request for review:
Bug 35347: Convert the zoom mode into a proper enum
https://bugs.webkit.org/show_bug.cgi?id=35347

Attachment 49401: Convert the zoom mode into a proper enum
https://bugs.webkit.org/attachment.cgi?id=49401&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +2010-02-24  Jakob Petsovits	<jakob.petsovits at torchmobile.com>

Please change to correct email address.

> diff --git a/WebCore/page/Settings.cpp b/WebCore/page/Settings.cpp
> index cc8f7af..a9f6c5c 100644
> --- a/WebCore/page/Settings.cpp
> +++ b/WebCore/page/Settings.cpp
> @@ -102,7 +102,7 @@ Settings::Settings(Page* page)
>      , m_inApplicationChromeMode(false)
>      , m_offlineWebApplicationCacheEnabled(false)
>      , m_shouldPaintCustomScrollbars(false)
> -    , m_zoomsTextOnly(false)
> +    , m_zoomMode(ZoomPage)

...

> @@ -309,6 +314,7 @@ namespace WebCore {
>	   size_t m_maximumDecodedImageSize;
>	   unsigned m_localStorageQuota;
>	   unsigned m_pluginAllowedRunTime;
> +	   ZoomMode m_zoomMode;
>	   bool m_isJavaEnabled : 1;
>	   bool m_loadsImagesAutomatically : 1;
>	   bool m_privateBrowsingEnabled : 1;
> @@ -347,7 +353,6 @@ namespace WebCore {
>	   bool m_inApplicationChromeMode : 1;
>	   bool m_offlineWebApplicationCacheEnabled : 1;
>	   bool m_shouldPaintCustomScrollbars : 1;
> -	   bool m_zoomsTextOnly : 1;
>	   bool m_enforceCSSMIMETypeInStrictMode : 1;
>	   bool m_usesEncodingDetector : 1;
>	   bool m_allowScriptsToCloseWindows : 1;

Incorrect initialization order...

Please update and fix above to produce a new patch.  Since this touches most
ports it'd be nice if the bots were working to check the build with this patch.