[webkit-reviews] review denied: [Bug 35341] Expose Database object of currently active task on the database thread : [Attachment 49390] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 35341: Expose Database object of currently active task on the database
thread
https://bugs.webkit.org/show_bug.cgi?id=35341

Attachment 49390: Patch
https://bugs.webkit.org/attachment.cgi?id=49390&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Close...but I think it's worth adding an assert.

> diff --git a/WebCore/storage/DatabaseThread.cpp
b/WebCore/storage/DatabaseThread.cpp
> index ec4c6d1..e5a21d1 100644
> --- a/WebCore/storage/DatabaseThread.cpp
> +++ b/WebCore/storage/DatabaseThread.cpp
> @@ -42,6 +42,7 @@ namespace WebCore {
>  
>  DatabaseThread::DatabaseThread()
>      : m_threadID(0)
> +    , m_databaseOfCurrentTask(0)
>      , m_transactionClient(new SQLTransactionClient())
>      , m_transactionCoordinator(new SQLTransactionCoordinator())
>      , m_cleanupSync(0)
> @@ -96,7 +97,9 @@ void* DatabaseThread::databaseThread()
>  
>      AutodrainedPool pool;
>      while (OwnPtr<DatabaseTask> task = m_queue.waitForMessage()) {

ASSERT it's 0 first

> +	   m_databaseOfCurrentTask = task->database();
>	   task->performTask();
> +	   m_databaseOfCurrentTask = 0;
>	   pool.cycle();
>      }