[webkit-reviews] review denied: [Bug 35148] Web Inspector: support debugging of workers. : [Attachment 49380] A patch to enable early injection of script into inspected page and a fake worker implementation to be injected when debugging workers is enabled

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 35148: Web Inspector: support debugging of workers.
https://bugs.webkit.org/show_bug.cgi?id=35148

Attachment 49380: A patch to enable early injection of script into inspected
page and a fake worker implementation to be injected when debugging workers is
enabled
https://bugs.webkit.org/attachment.cgi?id=49380&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +	       'inspector/front-end/InjectedFakeWorkers.js',

Rename to InjectedFrameWorker.js?

>  
> +void InjectedScriptHost::addScriptToEvaluateOnLoad(const String& source)
> +{
> +    m_scriptsToEvaluateOnLoad.append(source);
> +}
> +

> +void InjectedScriptHost::removeAllScriptsEvaluatedOnLoad()
> +{

Name is misleading - you don't really remove evaluated scripts.
removeAllScriptsToEvaluateOnLoad() ?


> +void InjectedScriptHost::evaluateOnLoadScripts(Frame *frame)
> +{

This could be done in InspectorBackend (or InspectorController) explicitly.