[webkit-reviews] review denied: [Bug 32993] Blob.slice support : [Attachment 49347] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 23 18:31:59 PST 2010
Dmitry Titov <dimich at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 32993: Blob.slice support
https://bugs.webkit.org/show_bug.cgi?id=32993
Attachment 49347: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=49347&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
The patch looks good to me.
I think the ENABLE_BLOB_SLICE should also be added into following files since
it's good to keep them in sync:
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
WebCore/WebCore.pri
WebCore/GNUMakefile.am (also it would be nice to replace spaces with tabs in
front of "WebCore/html/Blob.cpp,.h" in this file)
WebKit/chromium/features.gypi
r- because of this.
More information about the webkit-reviews
mailing list