[webkit-reviews] review granted: [Bug 35232] Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh. : [Attachment 49326] [PATCH] Proposed fix.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 35232: Web Inspector: Scripts panel shows blank source when stopping on a
breakpoint on refresh.
https://bugs.webkit.org/show_bug.cgi?id=35232

Attachment 49326: [PATCH] Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=49326&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   var prefix = [];
> +	   for (var i = 0; i < this.script.startingLine; ++i)
> +	       prefix.push("");
> +	   
> +	   this.sourceFrame.setContent("text/javascript", prefix.join("\n") +
this.script.source);

Why not just build a string by appending "\n"? I think JSC optimizes that case.



> +	       this._resourceForURLInFilesSelect[script.resource.url] =
script.resource;
> +	  }
> + 
> +	   var displayName = script.sourceURL ?
WebInspector.displayNameForURL(script.sourceURL) :
WebInspector.UIString("(program)");

Bad indent on the } line.