[webkit-reviews] review requested: [Bug 35137] Chromium: Use V8::TerminateExecution to actually terminate workers. : [Attachment 49335] Updated patch.

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 35137: Chromium: Use V8::TerminateExecution to actually terminate workers.
https://bugs.webkit.org/show_bug.cgi?id=35137

Attachment 49335: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=49335&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Updated patch as per email discussion with Mads Ager and Drew Wilson.
The way to check that v8 has returned from JS block because of
TerminateExecution() is to check TryCatch::CanContinue(). Added this check.
The v8 will unwind JS frames upon return from C++ frames because termination
exception is 'sticky'.

Independently from this patch, V8 team plans to look into a generic issue of
possible re-entering V8 while termination is in effect. It is unclear if we
even have this scenario in today's worker code.