[webkit-reviews] review granted: [Bug 30032] [Gtk] Creation of a WebkitWebView widget is very slow : [Attachment 49131] Updated patch (w/ ChangeLog & style issues fixed)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 14:22:29 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 30032: [Gtk] Creation of a WebkitWebView widget is very slow
https://bugs.webkit.org/show_bug.cgi?id=30032

Attachment 49131: Updated patch (w/ ChangeLog & style issues fixed)
https://bugs.webkit.org/attachment.cgi?id=49131&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
1276  GSList* webkit_web_settings_get_spell_languages(WebKitWebView *web_view)
 1272 GSList* webkit_web_settings_get_enchant_dicts(WebKitWebView* webView)
12771273 {
12781274     g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(web_view), 0);
12791275 
12801276     WebKitWebSettings* settings =
webkit_web_view_get_settings(web_view);

Looks like you need to adjust the variable name in the two calls above =). r+
with that change, and removing the else clause, as pointed by the style bot, if
you feel like committing it, Martin!


More information about the webkit-reviews mailing list