[webkit-reviews] review granted: [Bug 35274] REGRESSION(r55107): Inspector docking is busted. : [Attachment 49317] With pfeldman's requested change

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 35274: REGRESSION(r55107): Inspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274

Attachment 49317: With pfeldman's requested change
https://bugs.webkit.org/attachment.cgi?id=49317&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good. Single nit below:

> +    if (constrainedHeight > inspectedPageHeight *
maximumAttachedHeightRatio)
>	   return;

Same as before, this could be a change against minimumAttachedHeight. You can
then use constrainedAttachedWindowHeight in place below as it used to be.
Essentially your change will move from checks against preferredHeight to checks
against minimumAttachedHeight, rest of the code won't change.

> +	   if (x && InspectorFrontendHost.canAttachWindow &&
!InspectorFrontendHost.canAttachWindow())
> +	       return;

Thanks!