[webkit-reviews] review denied: [Bug 35153] [Qt] WebGL support missing in QtWebKit : [Attachment 49302] Qt WebGL support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 12:10:47 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jarkko Sakkinen
<jarkko.sakkinen at tieto.com>'s request for review:
Bug 35153: [Qt] WebGL support missing in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35153

Attachment 49302: Qt WebGL support
https://bugs.webkit.org/attachment.cgi?id=49302&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
I had a discussion with Jarkko on IRC and he is a.o updating the patch to make
use of a template for all calls similar to: 

#ifdef ...
enableVertexAttribArray =
reinterpret_cast<glEnableVertexAttribArrayType>(getProcAddress(ctx,
"glEnableVertexAttribArray"));
#else
enableVertexAttribArray = glEnableVertexAttribArray
#endif

that will simplify the code somewhat, as well as fixing coding styles issues
and the like.


More information about the webkit-reviews mailing list