[webkit-reviews] review granted: [Bug 35287] ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading : [Attachment 49304] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 35287: ImageSourceCG::frameIsCompleteAtIndex returns false for all frames
until image has completed loading
https://bugs.webkit.org/show_bug.cgi?id=35287

Attachment 49304: Patch
https://bugs.webkit.org/attachment.cgi?id=49304&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
It looks like the two values we're interested in, when testing "frameStatus >=
kCGImageStatusIncomplete", are:
    kCGImageStatusIncomplete = -1,
    kCGImageStatusComplete = 0

I think it would be better just to test them explicitly: "frameStatus ==
kCGImageStatusIncomplete || frameStatus == kCGImageStatusComplete".

This has the benefit of documenting which values we're testing for without
requiring the reader to flip to another file. Also, unless there's some
explicit API contract somewhere, it's probably better not to assume that
statuses >= kCGImageStatusIncomplete will always be "good" statuses.