[webkit-reviews] review denied: [Bug 35233] Optimize Latin-1 decoding in TextCodecLatin1::decode() : [Attachment 49275] Same patch, templates instead of ifdefs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 23 10:17:13 PST 2010
Darin Adler <darin at apple.com> has denied review:
Bug 35233: Optimize Latin-1 decoding in TextCodecLatin1::decode()
https://bugs.webkit.org/show_bug.cgi?id=35233
Attachment 49275: Same patch, templates instead of ifdefs
https://bugs.webkit.org/attachment.cgi?id=49275&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +template<> struct NonASCIIMask<8> {
> + static uintptr_t value() { return 0x8080808080808080UL; }
> +};
As I feared, this does not compile in 32-bit Mac.
I believe the right way to do this is this:
static unsigned long long value() { return 0x8080808080808080ULL; }
Should work on all platforms.
More information about the webkit-reviews
mailing list