[webkit-reviews] review denied: [Bug 35292] [Qt] Need a final integration between QtLauncher and QGVLauncher : [Attachment 49294] Clone Window feature - v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 07:14:29 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jesus
Sanchez-Palencia <jesus.palencia at openbossa.org>'s request for review:
Bug 35292: [Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292

Attachment 49294: Clone Window feature - v2
https://bugs.webkit.org/attachment.cgi?id=49294&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> -    LauncherWindow(QString url = QString());
> +    LauncherWindow(QString url = QString(), QGraphicsScene* scene = 0);

Doing two constructors seems better, with a private ::init() method.


More information about the webkit-reviews mailing list