[webkit-reviews] review requested: [Bug 34843] [Qt] QtScript should provide QScriptString : [Attachment 49286] Fix v4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 23 06:29:19 PST 2010
Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked for review:
Bug 34843: [Qt] QtScript should provide QScriptString
https://bugs.webkit.org/show_bug.cgi?id=34843
Attachment 49286: Fix v4
https://bugs.webkit.org/attachment.cgi?id=49286&action=review
------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
Changelog:
Algorithm was simplified.
Code was moved to the QScriptConverter class (there is high probability that it
will be reused from QScriptValue).
New test cases were added.
Fix conversion from float (ex. 0.3 is not a correct index array).
More information about the webkit-reviews
mailing list