[webkit-reviews] review denied: [Bug 35153] [Qt] WebGL support missing in QtWebKit : [Attachment 49279] Qt WebGL support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 05:46:29 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jarkko Sakkinen
<jarkko.sakkinen at tieto.com>'s request for review:
Bug 35153: [Qt] WebGL support missing in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35153

Attachment 49279: Qt WebGL support
https://bugs.webkit.org/attachment.cgi?id=49279&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +
> +typedef void (APIENTRY *glActiveTextureType) (GLenum);
> +typedef void (APIENTRY *glAttachShaderType) (GLuint, GLuint);
> +typedef void (APIENTRY *glBindAttribLocationType) (GLuint, GLuint, const
char *);
> +typedef void (APIENTRY *glBindBufferType) (GLenum, GLuint);

Lost of these have wrong coding style, like the * should be left aligned, thus:


+typedef void (APIENTRY* glBindAttribLocationType) (GLuint, GLuint, const
char*)

We are pretty strict about coding style in WebKit, thus r-. Please make use of
the tool check-webkit-style which can be found in WebKitTools/Scripts


More information about the webkit-reviews mailing list