[webkit-reviews] review requested: [Bug 34742] [Qt] tst_QWebPage::infiniteLoopJS() is inifinite on Symbian HW : [Attachment 49276] proposed fix for timeoutchecker.cpp

[bugzilla-daemon at webkit.org]

Janne Koskinen <koshuin at gmail.com> has asked  for review:
Bug 34742: [Qt] tst_QWebPage::infiniteLoopJS() is inifinite on Symbian HW
https://bugs.webkit.org/show_bug.cgi?id=34742

Attachment 49276: proposed fix for timeoutchecker.cpp
https://bugs.webkit.org/attachment.cgi?id=49276&action=review

------- Additional Comments from Janne Koskinen <koshuin at gmail.com>
Patch contains a proper implementation of getCPUTime for Symbian. It works from
Symbian 9.1 onwards i.e. S60 3rd edition and up as that is when GetCpuTime
function was introduced.
Tested the the patch to run on Nokia N95 and Nokia 5800 Express Music. It is
possible that some device doesn't implement the function or has it disabled,
thus added assertion for debugging purposes to see if some device returns
KErrNotSupported.

Also reported the gettimeofday -issue to Open C guys, so that will be fixed in
future releases.