[webkit-reviews] review requested: [Bug 35288] [Haiku] Implement ImageBuffer support : [Attachment 49273] Patch implementing StillImage class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 03:25:58 PST 2010


Stephan Aßmus <superstippi at gmx.de> has asked  for review:
Bug 35288: [Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288

Attachment 49273: Patch implementing StillImage class
https://bugs.webkit.org/attachment.cgi?id=49273&action=review

------- Additional Comments from Stephan Aßmus <superstippi at gmx.de>
The StillImage class wraps a native BBitmap in a WebCore::Image derived class.

A reviewer could check the destroyDecodedData() and decodedSize() methods.
Since StillImage will be used only for ImageBuffer implementation, and appear
to be short-lived, I don't believe image data needs to be pruned while keeping
the StillImage instance itself alive, but it would be nice to get a
confirmation.


More information about the webkit-reviews mailing list