[webkit-reviews] review denied: [Bug 35272] [Chromium] Implement WebDocument::getElementsByTagName : [Attachment 49248] [Chromium] Implement WebDocument::getElementsByTagName [try2]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 22:12:39 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Hawkins
<jhawkins at google.com>'s request for review:
Bug 35272: [Chromium] Implement WebDocument::getElementsByTagName
https://bugs.webkit.org/show_bug.cgi?id=35272

Attachment 49248: [Chromium] Implement WebDocument::getElementsByTagName [try2]
https://bugs.webkit.org/attachment.cgi?id=49248&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebDocument.h
...
>      WEBKIT_API WebElement getElementById(const WebString& id) const;
> +    WEBKIT_API WebNodeList getElementsByTagName(const WebString&);

hmm, it seems like getElementsByTagName (like getElementById) should be
a const method since it does not mutate WebDocument.


More information about the webkit-reviews mailing list