[webkit-reviews] review denied: [Bug 35207] all xhtml documents fail to render when XHTMLMP enabled : [Attachment 49145] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 14:28:30 PST 2010


Eric Seidel <eric at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 35207: all xhtml documents fail to render when XHTMLMP enabled
https://bugs.webkit.org/show_bug.cgi?id=35207

Attachment 49145: fix patch
https://bugs.webkit.org/attachment.cgi?id=49145&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Like george, I don't understand why this channges WML.	Not that the change is
wrong, it just needs more explanation.

It looks like this was always backwards:
	#if !ENABLE(XHTMLMP)
1256		|| (extId == "-//WAPFORUM//DTD XHTML Mobile 1.0//EN")
1257	#endif
?

Or if that should be enabled for all ports, just remove the #if.


More information about the webkit-reviews mailing list