[webkit-reviews] review granted: [Bug 34685] [Haiku] Fix various problems in mouse/wheel/keyboard event propagation : [Attachment 48977] Fixes to PlatformKeyboardEventHaiku.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 13:32:48 PST 2010


Eric Seidel <eric at webkit.org> has granted Stephan Aßmus <superstippi at gmx.de>'s
request for review:
Bug 34685: [Haiku] Fix various problems in mouse/wheel/keyboard event
propagation
https://bugs.webkit.org/show_bug.cgi?id=34685

Attachment 48977: Fixes to PlatformKeyboardEventHaiku.cpp
https://bugs.webkit.org/attachment.cgi?id=48977&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sad that this same code is copy/paste in all 3 platform events:
    int32 modifiers = message->FindInt32("modifiers");
 351	 m_shiftKey = modifiers & B_SHIFT_KEY;
 352	 m_ctrlKey = modifiers & B_COMMAND_KEY;
 353	 m_altKey = modifiers & B_CONTROL_KEY;
 354	 m_metaKey = modifiers & B_OPTION_KEY;

Looks good.


More information about the webkit-reviews mailing list