[webkit-reviews] review denied: [Bug 35087] New port: EFL; adding files to WebCore/*/efl : [Attachment 49227] Add EFL port files in WebCore/platform/efl

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35087: New port: EFL; adding files to WebCore/*/efl
https://bugs.webkit.org/show_bug.cgi?id=35087

Attachment 49227: Add EFL port files in WebCore/platform/efl
https://bugs.webkit.org/attachment.cgi?id=49227&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Half of your files are LGPL the other half are BSD.  Is this intentional?

Also, I don't understand why you're listing any copyright from 2008 (or before
2010).	If the work wasn't published, I'm not sure how it can have copyright.

I think normally we leave a blank line here, but I don't think there is an
official style:
+namespace WebCore {
+PassRefPtr<Clipboard> Editor::newGeneralClipboard(ClipboardAccessPolicy
policy)

This patch would be much easier to handle in smaller pieces.

See examples from other recent ports, like BREW or Haiku, how they posted
smaller patches grouped by related files.  Personally I target my patches to be
< 20k, although for simple patches like these that's not always needed.  The
problem here is that some of this patch is simple,a nd some of it actually has
real logic.  Would be much better to post the simple patches of just
"notImplemented()" code in a separate patch.