[webkit-reviews] review denied: [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame : [Attachment 49148] patch v1

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 35210: [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

Attachment 49148: patch v1
https://bugs.webkit.org/attachment.cgi?id=49148&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Thanks for the patch! I think the idea of a signal is a good one, but I think
the frame_allow_geolocation function is not a very good interface. I think the
signal should probably return a boolean to set if it is handled or not, and we
could use a policy object, similar to the WebPolicyDecision. So, say,
GeolocationPolicyDecision. You would emit the signal, and you would have a
default implementation that denies the policy decision. I think that will allow
us flexibility to further improve the API as the web standards move forward.
I'll CC xan here, too, so he can comment. You also need to address the style
issues.