[webkit-reviews] review denied: [Bug 34940] [Gtk] testwebview does not work when called with absolute path : [Attachment 49091] patch v2.2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 22 09:17:17 PST 2010
Gustavo Noronha (kov) <gns at gnome.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 34940: [Gtk] testwebview does not work when called with absolute path
https://bugs.webkit.org/show_bug.cgi?id=34940
Attachment 49091: patch v2.2
https://bugs.webkit.org/attachment.cgi?id=49091&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
30 extern int testutils_relative_chdir(const gchar*, const gchar*);
Adding a header, and a proper signature would be better, plus, you should add
the bug URL, and its description to the changelog:
8 Need a short description and bug URL (OOPS!)
Otherwise, this patch is a good step forward, thanks for taking the time to
refactor this! One more round to fix up these two small issues, and I'll r+ it.
More information about the webkit-reviews
mailing list