[webkit-reviews] review requested: [Bug 34850] [Qt] QScriptValue::toString() returns incorrect values : [Attachment 49210] Fix v4

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked  for review:
Bug 34850: [Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850

Attachment 49210: Fix v4
https://bugs.webkit.org/attachment.cgi?id=49210&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
(In reply to comment #5)
> (From update of attachment 49063 [details])
> Looks sane to me, except...
> 
> > +	     QByteArray buf;
> > +	     buf.reserve(80);
> 
> ..where does this value come from? I can't recall you can print a double
value
> into 80-char long string.
> 
> Maybe add some comment or use shorter buffer length for that?

2^64 => 20 digits + 1 sign
min double (-1.7976931348623158e+308) => 20 digits + 4 others

It seems that 24 is enough, but I'm not really sure :-).