[webkit-reviews] review granted: [Bug 35226] Cache JavaScript wrappers inline in DOM nodes : [Attachment 49181] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 21 20:34:53 PST 2010
Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 35226: Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
Attachment 49181: Patch
https://bugs.webkit.org/attachment.cgi?id=49181&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> void forgetDOMObject(DOMObject* wrapper, void* objectHandle)
> {
> +
> JSC::JSGlobalData* globalData = Heap::heap(wrapper)->globalData();
No need for this added blank line.
> - JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Document*, Node*);
> + JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Node*);
This is defined in JSNodeCustom.h instead of this header. Why?
> + inline DOMObjectWrapperMap& DOMObjectWrapperMapFor(JSC::ExecState* exec)
> + {
> + return currentWorld(exec)->m_wrappers;
> + }
In the past we have lowercased even acronyms like DOM here at the start of a
function name. Maybe there's some way to dodge the issue.
r=me
More information about the webkit-reviews
mailing list