[webkit-reviews] review granted: [Bug 22215] Avoid calling absoluteClippedOverflowRect() so many times : [Attachment 49160] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 21 12:09:54 PST 2010


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 22215: Avoid calling absoluteClippedOverflowRect() so many times
https://bugs.webkit.org/show_bug.cgi?id=22215

Attachment 49160: Patch
https://bugs.webkit.org/attachment.cgi?id=49160&action=review

------- Additional Comments from mitz at webkit.org
Debug builds could continue to compute the values and assert that they are
equal to the passed-in precomputed values, if present. I also think that the
“Rect” suffix isn’t a very clear way to distinguish between the arguments and
the local variables (which are also rects!). A “Ptr” suffix or “precomputed”
prefix might be clearer.

P.S. r=me


More information about the webkit-reviews mailing list