[webkit-reviews] review requested: [Bug 28799] REGRESSION(r47686-r47783): Debugger no longer works on reload : [Attachment 49150] [PATCH] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 21 06:50:06 PST 2010


Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 28799: REGRESSION(r47686-r47783): Debugger no longer works on reload
https://bugs.webkit.org/show_bug.cgi?id=28799

Attachment 49150: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=49150&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Sorry about the big change, but it mostly contains mechanical changes described
in the change log. It is just that I needed to persist breakpoints in
InspectorController and decided to reuse JavaScriptDebugServer's
BreakpointInfo. Then I saw that we have too much unnecessary complexity around
if(USE_JSC) vs JavaScriptDebugServer in InspectorController/Backend/Frontend
and moved server content to bindings.

This change does not fix the bug on its own. It makes debugger stop on
breakpoints while loading page, but it does not show the source. Reason is that
resource loading is not yet finished and it is still 'Other' viewer that has no
source frame. I will follow up with another change within the same bug.


More information about the webkit-reviews mailing list